A Project for Chronicle 4 based on L2JServer.


    Exploit/Bug

    Share
    avatar
    Karakan

    Posts : 428
    Join date : 2013-10-04

    Exploit/Bug

    Post  Karakan on 11th January 2015, 17:09

    If you attack a player/mob and quickly equip/unequip a weapon , your attack animation will be super fast and youll be able to kill everything faster.


    Tested vs. Player

    Hotkey F1 : Attack
    Hotkey F2 : Weapon


    This can be abused in pvp/farming/olympiad
    avatar
    DnR
    Admin
    Admin

    Posts : 1027
    Join date : 2012-12-03

    Re: Exploit/Bug

    Post  DnR on 11th January 2015, 18:44

    Here is a check already done in UseItem.java.
    Code:

                // If player is attacking, stop auto attack
                if (activeChar.getAI() != null)
                {
                    if (activeChar.getAI().getIntention() == CtrlIntention.AI_INTENTION_ATTACK)
                    {
                        activeChar.abortAttack();
                        activeChar.getAI().setIntention(CtrlIntention.AI_INTENTION_IDLE);
                    }
                }

    You tell me that it's still possible?
    avatar
    Karakan

    Posts : 428
    Join date : 2013-10-04

    Re: Exploit/Bug

    Post  Karakan on 11th January 2015, 18:58

    Sadly yes.
    Tested few times with different weapons.
    Works only on close range.

    Maybe a 5 second equip/unequip timer (FloodProtector?) would help?
    Even if its not retailish



    Edit : Temp. workaround.

    Code:
    +++ D:/workspace/Lisvus_GameServer/java/net/sf/l2j/gameserver/clientpackets/UseItem.java (working copy)
    @@ -241,22 +241,19 @@
             if (item.isEquipable())
             {
                 // No unequipping/equipping while the player is casting a skill
    -            if (activeChar.isCastingNow())
    + if (activeChar.isAttackingNow() || activeChar.isCastingNow() ||activeChar.isInCombat())


    Last edited by Karakan on 16th January 2015, 12:58; edited 1 time in total
    avatar
    Karakan

    Posts : 428
    Join date : 2013-10-04

    Re: Exploit/Bug

    Post  Karakan on 12th January 2015, 13:45

    Also happens when using a skill and pressing "/attack" rapidly.
    avatar
    Karakan

    Posts : 428
    Join date : 2013-10-04

    Re: Exploit/Bug

    Post  Karakan on 16th January 2015, 12:58

    Bump !
    avatar
    DnR
    Admin
    Admin

    Posts : 1027
    Join date : 2012-12-03

    Re: Exploit/Bug

    Post  DnR on 16th January 2015, 14:42

    I'm trying to find a proper fix for fast atk speed bug, so as not to block equip/unequip like before. For the time being, i suggest you using the check you mention above.
    About skill related bug, I would be grateful if you explained it with more details.
    avatar
    Karakan

    Posts : 428
    Join date : 2013-10-04

    Re: Exploit/Bug

    Post  Karakan on 16th January 2015, 22:53

    Odair explained it very well here...

    http://l2jlisvus.great-forum.com/t873-bug-attack-speed-on-skill-reload


    If you keep spamming F1 [Attack hotkey] and a skill in the hotbar simultanously.
    After some time youll get super fast atk spd.
    You stats wont change , but hit way faster and kill everything way faster.

    No error msgs in the log files

    I guess it has something to do with the "Skill is not availabe at this time...." msg in the client.
    Maybe that causes a server -> client lag ?


    I hope this can be fixed Smile

    Rergards
    avatar
    Maneco2

    Posts : 71
    Join date : 2015-01-11
    Age : 26
    Location : United States

    Re: Exploit/Bug

    Post  Maneco2 on 17th January 2015, 01:55

    Downlaod my Replay Video... Updated!!!
    C:\Program Files (x86)\LineageII\Replay
    mega.co.nz #!TMEgQYKT!yx2hXTZIoWarvYXgDQnCStdQrKWOP7dH80SsiKFcme4
    avatar
    DnR
    Admin
    Admin

    Posts : 1027
    Join date : 2012-12-03

    Re: Exploit/Bug

    Post  DnR on 17th January 2015, 11:05

    It seems like i can't do it, but i'm looking for code leaks.

    I suspect that's the problem.
    Could you at least test it for me?

    Code:
            // Check if skill is disabled (part 1)
            if (isSkillDisabled(skill.getId()))
            {
    -           int radius = getMagicalAttackRange(skill);
    -           if (target instanceof L2Character)
    -               radius += (int)((L2Character)target).getTemplate().collisionRadius;
    -           if (skill.getCastRange() < 0 || isInsideRadius(target, radius, false, false))
    -           {
                    SystemMessage sm = new SystemMessage(SystemMessage.S1_PREPARED_FOR_REUSE);
                    sm.addSkillName(skill.getId(),skill.getLevel());
                    sendPacket(sm);
                    return;
    -           }
            }
    avatar
    Maneco2

    Posts : 71
    Join date : 2015-01-11
    Age : 26
    Location : United States

    Re: Exploit/Bug

    Post  Maneco2 on 17th January 2015, 13:23

    DnR wrote:It seems like i can't do it, but i'm looking for code leaks.

    I suspect that's the problem.
    Could you at least test it for me?

    Code:
            // Check if skill is disabled (part 1)
            if (isSkillDisabled(skill.getId()))
            {
    -           int radius = getMagicalAttackRange(skill);
    -           if (target instanceof L2Character)
    -               radius += (int)((L2Character)target).getTemplate().collisionRadius;
    -           if (skill.getCastRange() < 0 || isInsideRadius(target, radius, false, false))
    -           {
                    SystemMessage sm = new SystemMessage(SystemMessage.S1_PREPARED_FOR_REUSE);
                    sm.addSkillName(skill.getId(),skill.getLevel());
                    sendPacket(sm);
                    return;
    -           }
            }

    yes is correct, you can fix this by modifying, I tested and fixed! Very Happy
    avatar
    Karakan

    Posts : 428
    Join date : 2013-10-04

    Re: Exploit/Bug

    Post  Karakan on 17th January 2015, 14:28

    Going to test it on live today and will report back.
    avatar
    Maneco2

    Posts : 71
    Join date : 2015-01-11
    Age : 26
    Location : United States

    Re: Exploit/Bug

    Post  Maneco2 on 17th January 2015, 14:29

    I tested this morning, that's right, that fixes the exploit attack speed by skills
    avatar
    Karakan

    Posts : 428
    Join date : 2013-10-04

    Re: Exploit/Bug

    Post  Karakan on 17th January 2015, 16:04

    It indeed fixed the atk spd bug when you keep pressing both hotkeys.
    Thanks DnR!! Smile

    But : Exploit still can be used when you equip/unequip weapons like mentioned on first post.
    avatar
    DnR
    Admin
    Admin

    Posts : 1027
    Join date : 2012-12-03

    Re: Exploit/Bug

    Post  DnR on 17th January 2015, 16:18

    It's all thanks to the clues given by you guys. Smile

    Unfortunately, i haven't found a solution about equip/unequip bug yet.
    I reverted it to good old fix (the code you posted above).

    Please both of you test these exploits in revision 507.
    I commited it as fast as i could, as it has to do with exploiting.
    I modded skill disability checks, so that it won't ruin other features.
    avatar
    Maneco2

    Posts : 71
    Join date : 2015-01-11
    Age : 26
    Location : United States

    Exploit/Bug

    Post  Maneco2 on 17th January 2015, 16:43

    I'll try to help it, I see something here
    avatar
    Maneco2

    Posts : 71
    Join date : 2015-01-11
    Age : 26
    Location : United States

    Exploit/Bug

    Post  Maneco2 on 17th January 2015, 18:07

    Fixed and tested!!! Very Happy
    Code:

    --- java/net/sf/l2j/gameserver/clientpackets/AttackRequest.java (révision 507)
    +++ java/net/sf/l2j/gameserver/clientpackets/AttackRequest.java (working copy)

                target.onAction(activeChar);
            else
            {
    -            if (target.getObjectId() != activeChar.getObjectId() && activeChar.getPrivateStoreType() == 0 && activeChar.getActiveRequester() == null)
    +            if ((target.getObjectId() != activeChar.getObjectId()) && activeChar.getPrivateStoreType() == 0 && activeChar.getActiveRequester() == null)
                    target.onForcedAttack(activeChar);
                else
                    activeChar.sendPacket(new ActionFailed());

    avatar
    DnR
    Admin
    Admin

    Posts : 1027
    Join date : 2012-12-03

    Re: Exploit/Bug

    Post  DnR on 17th January 2015, 18:26

    Odair wrote:Fixed and tested!!! Very Happy
    Code:

    --- java/net/sf/l2j/gameserver/clientpackets/AttackRequest.java (révision 507)
    +++ java/net/sf/l2j/gameserver/clientpackets/AttackRequest.java (working copy)

                target.onAction(activeChar);
            else
            {
    -            if (target.getObjectId() != activeChar.getObjectId() && activeChar.getPrivateStoreType() == 0 && activeChar.getActiveRequester() == null)
    +            if ((target.getObjectId() != activeChar.getObjectId()) && activeChar.getPrivateStoreType() == 0 && activeChar.getActiveRequester() == null)
                    target.onForcedAttack(activeChar);
                else
                    activeChar.sendPacket(new ActionFailed());


    What's the problem here?
    avatar
    Maneco2

    Posts : 71
    Join date : 2015-01-11
    Age : 26
    Location : United States

    Exploit/Bug

    Post  Maneco2 on 17th January 2015, 18:29

    Line 92
    Code:
    if (target.getObjectId() != activeChar.getObjectId()
    lack a parameter...
    change to -->
    Code:
    if ((target.getObjectId() != activeChar.getObjectId())
    avatar
    Karakan

    Posts : 428
    Join date : 2013-10-04

    Re: Exploit/Bug

    Post  Karakan on 17th January 2015, 18:36

    You'r sure this was causing it ?
    Ill test it when im back @home.
    Regards^^
    avatar
    Maneco2

    Posts : 71
    Join date : 2015-01-11
    Age : 26
    Location : United States

    Re: Exploit/Bug

    Post  Maneco2 on 17th January 2015, 18:47

    Karakan wrote:If you attack a player/mob and quickly equip/unequip a weapon , your attack animation will be super fast and youll be able to kill everything faster.


    Tested vs. Player

    Hotkey F1 : Attack
    Hotkey F2 : Weapon


    This can be abused in pvp/farming/olympiad
    I tested and everything is fixed in revision 507
    equip/unequip and skills reload no?
    avatar
    Karakan

    Posts : 428
    Join date : 2013-10-04

    Re: Exploit/Bug

    Post  Karakan on 17th January 2015, 20:35

    Great!! Smile
    This caused lots of bans lately on my server. lol
    Gonna update live server tomorrow.

    Thanks guys !!!
    avatar
    Maneco2

    Posts : 71
    Join date : 2015-01-11
    Age : 26
    Location : United States

    Re: Exploit/Bug

    Post  Maneco2 on 17th January 2015, 20:43

    yes I made a mistake before, the bug was already fixed, I did the update a few minutes ago and tested equip/unequip Very Happy

    Sponsored content

    Re: Exploit/Bug

    Post  Sponsored content


      Current date/time is 22nd November 2017, 05:49